Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-immediate jumps #52

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Remove non-immediate jumps #52

merged 2 commits into from
Feb 10, 2021

Conversation

adlerjohn
Copy link
Contributor

  • Add an "instruction start" reserved register, $is. The more obvious name "code pointer" is probably a bad idea because $cp is too close to $pc and hard to read accurately when looking at assembly.
  • Use the instruction start implicitly for all jumps and forbid non-immediate jumps for safety.

@adlerjohn adlerjohn added the enhancement New feature or request label Feb 9, 2021
@adlerjohn adlerjohn self-assigned this Feb 9, 2021
@adlerjohn adlerjohn requested a review from sezna February 9, 2021 22:30
@adlerjohn adlerjohn merged commit cee8651 into master Feb 10, 2021
@adlerjohn adlerjohn deleted the adlerjohn-jump_code_pointer branch February 10, 2021 01:38
@adlerjohn adlerjohn mentioned this pull request Feb 10, 2021
Merged
@adlerjohn adlerjohn added the comp:FVM Component: FuelVM label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezna sezna sezna approved these changes

Assignees

@adlerjohn adlerjohn

Labels
comp:FVM Component: FuelVM enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adlerjohn @sezna