Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize consumed gas calculation #29

Closed
vlopes11 opened this issue Oct 6, 2021 · 2 comments · Fixed by #40
Closed

Optimize consumed gas calculation #29

vlopes11 opened this issue Oct 6, 2021 · 2 comments · Fixed by #40
Labels
fuel-vm Related to the `fuel-vm` crate.

Comments

@vlopes11
Copy link
Contributor

vlopes11 commented Oct 6, 2021

The gas charge function is designed in a way to make it possible to use constants for most of opcodes that charge gas based on constants, and use callbacks for opcodes with variable gas cost (example: ALOC).

The execute function must be refactored to reduce the match count to one and then benefit of constant gas cost calculation.
@vlopes11
Copy link
Contributor Author

vlopes11 commented Oct 6, 2021

Blocked by #30

This was referenced Oct 6, 2021
Closed
Merged
@vlopes11
Copy link
Contributor Author

vlopes11 commented Nov 1, 2021

Fixed in #40

@vlopes11 vlopes11 closed this as completed Nov 1, 2021
@adlerjohn adlerjohn linked a pull request Nov 2, 2021 that will close this issue
Refactor execute to parse Word in pairs #40
Merged
ControlCplusControlV pushed a commit that referenced this issue Nov 24, 2022
@vlopes11
Add From<Opcode> for Instruction (#29)
7c8f4b6
ControlCplusControlV pushed a commit that referenced this issue Nov 24, 2022
@Voxelot
matrix build and add clippy (#29)
5677a59
ControlCplusControlV pushed a commit that referenced this issue Dec 1, 2022
@vlopes11
Add From<Opcode> for Instruction (#29)
b490439
ControlCplusControlV pushed a commit that referenced this issue Dec 1, 2022
@Voxelot
matrix build and add clippy (#29)
ac5a07d
mitchmindtree pushed a commit that referenced this issue Dec 5, 2022
@vlopes11
Bump to v0.6.0 (#29)
1ba88dc
@mitchmindtree mitchmindtree added the fuel-vm Related to the `fuel-vm` crate. label Dec 9, 2022
xgreenx pushed a commit that referenced this issue Dec 20, 2022
@Voxelot @xgreenx
matrix build and add clippy (#29)
f636981
xgreenx pushed a commit that referenced this issue Dec 20, 2022
@vlopes11 @xgreenx
Add From<Opcode> for Instruction (#29)
481b4fd
xgreenx pushed a commit that referenced this issue Dec 20, 2022
@vlopes11 @xgreenx
Bump to v0.6.0 (#29)
32e475a
xgreenx pushed a commit that referenced this issue Dec 20, 2022
@Voxelot @xgreenx
matrix build and add clippy (#29)
b13dd20
xgreenx pushed a commit that referenced this issue Dec 20, 2022
@vlopes11 @xgreenx
Add From<Opcode> for Instruction (#29)
ac8e4e6
xgreenx pushed a commit that referenced this issue Dec 20, 2022
@vlopes11 @xgreenx
Bump to v0.6.0 (#29)
340deba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fuel-vm Related to the `fuel-vm` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor execute to parse Word in pairs FuelLabs/fuel-vm
2 participants
@mitchmindtree @vlopes11