Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't build proxy agent when env 'http_proxy' is empty #521

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

lilasxie
Copy link
Contributor

Running fuelup component list with empty http_proxy environment value will cause failed to get latest version info.

We should check http_proxy environment value before building proxy agent.

Installed:
  forc 0.46.1 (latest: failed to get latest version)
    - forc-fmtforc-lspforc-docforc-deployforc-run
  forc-explore 0.28.1 (latest: failed to get latest version)
  forc-index 0.23.0 (latest: failed to get latest version)
  forc-wallet 0.3.0 (latest: failed to get latest version)
  fuel-core 0.20.5 (latest: failed to get latest version)
  fuel-core-keygen : failed getting current version
  fuel-indexer 0.23.0 (latest: failed to get latest version)

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023

CLA assistant check
All committers have signed the CLA.

@sdankel
Copy link
Member

sdankel commented Dec 4, 2023

Could you paste the full command you're using to repro this?

@lilasxie
Copy link
Contributor Author

lilasxie commented Dec 5, 2023

Could you paste the full command you're using to repro this?

This maybe not bug for fuelup, but for a wrong http proxy setting. As I unset http proxy with export http_proxy="" by mistake, and cause the problem. But it would be better if we check the empty http proxy setting in my opinion.

src/download.rs Outdated Show resolved Hide resolved
@sdankel sdankel enabled auto-merge (squash) January 3, 2024 03:22
@sdankel sdankel merged commit 73a81be into FuelLabs:master Jan 3, 2024
16 checks passed
@lilasxie lilasxie deleted the fix/http_proxy branch January 3, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants