Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap ci tests #56

Merged
merged 7 commits into from
Jun 6, 2022
Merged

bootstrap ci tests #56

merged 7 commits into from
Jun 6, 2022

Conversation

eightfilms
Copy link
Contributor

Should close #2 for good, because testing is the only missing step.

  • bootstrapping with a simple test just so we can get a test CI up and running.
  • don't think other areas of the code are valid for testing now, perhaps we might want a more comprehensive test suite (i like cargo's one more than rustup's) once we get more commands up and running

@eightfilms
Copy link
Contributor Author

eightfilms commented Jun 2, 2022

marking this as ready for review since I think there's not much else to add for now. It's iffy trying to test filesystem operations, and I don't think it's very useful to test interactions with GitHub.

Hoping to adopt more of a TDD approach when expanding on new features. At some point we should also eventually have integration tests that runs the CLI and calls each command, and assert that the output is fine.

I think we have a good start with just bootstrapping tests in the CI, and this PR accomplished that goal.

@eightfilms eightfilms marked this pull request as ready for review June 2, 2022 01:19
@eightfilms eightfilms merged commit bfde98a into master Jun 6, 2022
@eightfilms eightfilms deleted the binggh/tests branch June 6, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add CI for building, testing, publishing
2 participants