Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance to toolchain install #575

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Enhance to toolchain install #575

merged 1 commit into from
Feb 19, 2024

Conversation

crodas
Copy link
Contributor

@crodas crodas commented Feb 19, 2024

Fixes #558

When updating the current toolchain this used to be output

image

This is the output now:

image

This change only affects updates, new installation have the same output

image

@crodas crodas self-assigned this Feb 19, 2024
@crodas crodas enabled auto-merge (squash) February 19, 2024 21:29
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Another enhancement would be to only show "Downloading: {}" and the download bars, none of the other messages, unless the verbose flag is given. I did a similar thing in forc with the tracing library, so that we only need to change the info!s to debug!s for the things we want to hide.

@crodas crodas merged commit 4f673cb into master Feb 19, 2024
15 checks passed
@crodas crodas deleted the enhacement-installation branch February 19, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fuelup toolchain install <name>
2 participants