Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the indoc crate to help clean up examples #639

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

JoshuaBatty
Copy link
Member

closes #638

@JoshuaBatty JoshuaBatty self-assigned this Jun 25, 2024
@JoshuaBatty JoshuaBatty requested a review from a team June 25, 2024 01:37
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) June 25, 2024 01:44
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also use it for:

fuelup/tests/default.rs

Lines 60 to 63 in 2d81994

"Toolchain with name 'nightly-{}' does not exist\n\n\
\u{1b}[1mInstalled toolchains\u{1b}[0m\n\
--------------------\n\
latest-{}\n\n",

to remove the need of explicitly using /n in the expected case or if you think these are fine, happy to approve.

@JoshuaBatty
Copy link
Member Author

Should we also use it for:

fuelup/tests/default.rs

Lines 60 to 63 in 2d81994

"Toolchain with name 'nightly-{}' does not exist\n\n\
\u{1b}[1mInstalled toolchains\u{1b}[0m\n\
--------------------\n\
latest-{}\n\n",

to remove the need of explicitly using /n in the expected case or if you think these are fine, happy to approve.

Yeah good call, might as well add it here as well. Will push a commit now

@JoshuaBatty
Copy link
Member Author

actually i'll leave it as is for now as these contain bold formatting in places.

@JoshuaBatty JoshuaBatty requested review from a team and kayagokalp June 25, 2024 04:28
@JoshuaBatty JoshuaBatty merged commit acee544 into master Jun 25, 2024
16 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/indoc branch June 25, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the indoc crate to help clean up examples
2 participants