Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend finding components to plugins and executables distributed by forc (#652) #666

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alfiedotwtf
Copy link
Contributor

When checking if a component is distributed by forc, we currently only look at forc's direct executables. This needs to be extended to resolve components, plugins, and executables.

This fixes a few issues found while investigating #665.

…orc (#652)

- Move function from Components to Component as we are dealing with only a
  single component for each call
@alfiedotwtf alfiedotwtf added bug Something isn't working code quality fuelup labels Oct 4, 2024
@alfiedotwtf alfiedotwtf requested a review from a team October 4, 2024 07:16
@alfiedotwtf alfiedotwtf self-assigned this Oct 4, 2024
@fuel-service-user
Copy link
Contributor

LCOV of commit 2abac56 during CI #2044

Summary coverage rate:
  lines......: 81.3% (2315 of 2846 lines)
  functions..: 44.0% (363 of 825 functions)
  branches...: 58.4% (277 of 474 branches)

Files changed coverage rate: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality fuelup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants