Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mainnet channel, remove betas #677

Merged
merged 10 commits into from
Oct 15, 2024
Merged

feat: add mainnet channel, remove betas #677

merged 10 commits into from
Oct 15, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Oct 15, 2024 •
edited
Loading

  • adds mainnet channel
  • removes betas 1-5, and devnet

@sdankel sdankel mentioned this pull request Oct 15, 2024
Merged
@fuel-service-user
Copy link
Contributor

fuel-service-user commented Oct 15, 2024 •
edited
Loading

LCOV of commit 90d6fa5 during CI #2063

Summary coverage rate:
  lines......: 81.8% (2294 of 2805 lines)
  functions..: 44.4% (363 of 818 functions)
  branches...: 58.1% (264 of 454 branches)

Files changed coverage rate: n/a

@sdankel sdankel marked this pull request as ready for review October 15, 2024 18:59
@sdankel sdankel requested review from kayagokalp and JoshuaBatty and removed request for kayagokalp October 15, 2024 18:59
kayagokalp
kayagokalp reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we first merge #676 and see if this actually works? Right now building this branch and executing fuelup default mainnet is not working for me. I think reserved channel logic is working (I can see that it is getting aliased into mainnet-aarch64-apple-darwin correctly) but since we lack the channel toml it is not installing anything?

src/channel.rs Outdated Show resolved Hide resolved
kayagokalp
kayagokalp previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

kayagokalp
kayagokalp previously approved these changes Oct 15, 2024
View reviewed changes
@sdankel sdankel merged commit b442d9e into master Oct 15, 2024
17 checks passed
@sdankel sdankel deleted the sophie/mainnet-rm-betas branch October 15, 2024 20:26
@kayagokalp kayagokalp mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@JoshuaBatty JoshuaBatty Awaiting requested review from JoshuaBatty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdankel @fuel-service-user @kayagokalp