Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging DataArrays with different dimenisionalities #800

Closed
jgrewe opened this issue Nov 22, 2019 · 3 comments
Closed

Tagging DataArrays with different dimenisionalities #800

jgrewe opened this issue Nov 22, 2019 · 3 comments
Assignees

Comments

@jgrewe
Copy link
Member

jgrewe commented Nov 22, 2019

So far a single Tags (and MTags) can only tag DataArrays that have the same dimensionality. We will make this a more flexible by implementing the following rules.

  1. The coordinates used in a Tag are applied first to last to the dimensions of referenced DataArrays. Errors will be raised if position, extent and unit can not be applied.
  2. If there are more coordinates in the Tag than there are dimensions in the DataArray, the superfluous coordinates will be ignored.
  3. If there are less coordinates in the Tag than there are dimensions in the DataArray, the full extent of the dimensions is assumed. (e.g. the tag points to a region of interest in a 2D DataArray and I now want to access the data of a 3D DataArray. The ROI coordinates are applied to the first two dims, while the slices extends across the full 3rd dimension).

First step before we come up with a wildcard tagging as proposed in #793

@jgrewe
Copy link
Member Author

jgrewe commented Nov 22, 2019

should be supported in 1.4 and 1.5

@jgrewe jgrewe changed the title Tagging DataArays with different dimenisionality Tagging DataArrays with different dimenisionalities Nov 22, 2019
@achilleas-k
Copy link
Member

The only point I'm not fully on board with is the second one. I guess you want to have the flexibility to tag 3 dimensions, then reference a 3D array and a 2D array and have the 2D array ignore tag dim 3?

@jgrewe jgrewe mentioned this issue Nov 26, 2019
@jgrewe
Copy link
Member Author

jgrewe commented Apr 14, 2020

closing since done for 1.4 and 1.5

@jgrewe jgrewe closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants