Update scatter.glsl to fix issue with textures #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @PMunkes , thanks for looking into this. I'll come back to it in a few weeks, family matters to attend to first. But I wanted you to know are not being ignored :-) |
|
Hi @GPSnoopy, take your time, there is no urgency here. I really enjoy experimenting with this project, so don't be surprised if there's another Pull Request when you return. |
This change fixes GPSnoopy#36 without any visual impact. The problem resulted from non-specified nonuniform texture indices. As the compiler is allowed to assume uniformity in certain variables, unless specified, this was a bug. https:/KhronosGroup/GLSL/blob/master/extensions/ext/GL_EXT_nonuniform_qualifier.txt
|
Updated the pull request since I found the root cause. |
GPSnoopy
reviewed
Mar 1, 2021
|
Found a very interesting link, in case anyone finds this later and wants more information: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change fixes #36 without any visual impact.