chore: remove legacy display currency converter #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindard
force-pushed
the
remove-legacy-display-currency-converter
branch
2 times, most recently
from
d20001d
to
d6df84e
Compare
vindard
force-pushed
the
remove-legacy-display-currency-converter
branch
4 times, most recently
from
2d5daf3
to
2b06df3
Compare
vindard
force-pushed
the
remove-legacy-display-currency-converter
branch
from
2b06df3
to
f2324e9
Compare
vindard
force-pushed
the
remove-legacy-display-currency-converter
branch
from
f2324e9
to
ae91e41
Compare
dolcalmi
requested changes
Feb 13, 2023
Comment on lines
+28
to
+35
| export const getCurrentPriceAsPriceRatio = async ({ | ||
| currency, | ||
| }: GetCurrentSatPriceArgs): Promise<PriceRatio | PriceServiceError> => { | ||
| const price = await getCurrentSatPrice({ currency }) | ||
| if (price instanceof Error) return price | ||
|
|
||
| return toPriceRatio(price.price * CENTS_PER_USD) | ||
| } |
There was a problem hiding this comment.
were you getting an error without this? in theory if code did not change this is not necessary
There was a problem hiding this comment.
Yup tests fail with "undefined" function for that method
| export const toDisplayCurrencyBaseAmount = (amount: number) => | ||
| amount as DisplayCurrencyBaseAmount | ||
|
|
||
| export const DisplayCurrencyConverter = ( |
There was a problem hiding this comment.
will we remove/rename NewDisplayCurrencyConverter in a different PR?
There was a problem hiding this comment.
Yup, removing in a follow-up one
dolcalmi
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes remaining instances of
DisplayCurrencyConverterand then removesDisplayCurrencyConverterimplementation.