Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax for loading sample datasets in gallery examples #1749

Merged
merged 3 commits into from
Feb 13, 2022

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Feb 12, 2022

Description of proposed changes

This PR is a follow-up of #1685 and updates the syntax for loading sample datasets in all corresponding gallery examples.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

This PR is a follow-up of #1685 and updates the syntax for loading sample datasets in all corresponding gallery examples.
@michaelgrund michaelgrund added the deprecation Deprecating a feature label Feb 12, 2022
@michaelgrund michaelgrund added this to the 0.6.0 milestone Feb 12, 2022
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Feb 12, 2022
@seisman seisman merged commit 11a50c3 into main Feb 13, 2022
@seisman seisman deleted the update-syntax-examples branch February 13, 2022 04:43
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants