Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter get_defined_contact_role is not defined #12533

Open
etj opened this issue Aug 29, 2024 · 3 comments
Open

Filter get_defined_contact_role is not defined #12533

etj opened this issue Aug 29, 2024 · 3 comments
Labels

Comments

@etj
Copy link
Contributor

etj commented Aug 29, 2024

The filter is only referenced once in the full_metadata.xml file:

{% for contact_roles, label in layer.get_defined_contact_roles %}

The contact roles are not added in the XML metadata document indeed.

Only checked on master, probably it's also on other branches.

@gannebamm
Copy link
Contributor

@ahmdthr maybe this is related to our issue with GDI-DE compatability and missing entries in the XML (https:/Thuenen-GeoNode-Development/Sprints/issues/6 & Thuenen-GeoNode-Development/thuenen_atlas#34)?

@ahmdthr
Copy link
Contributor

ahmdthr commented Aug 29, 2024

@gannebamm Let me take a look in detail.

@etj It most probably is referring to:

def get_defined_multivalue_contact_roles(self) -> List[Tuple[List[settings.AUTH_USER_MODEL], str]]:

but I will take a look at it soon, and report back.

@ahmdthr
Copy link
Contributor

ahmdthr commented Sep 4, 2024

@gannebamm Our GDI-DE compliance issue was not really related to this, but our generated metadata didn't include multiple contacts. But it is now fixed, we now get a GDI-DE compliant metadata with multiple contacts.

@etj As I suspected, incorrect property was being referred. I have created a PR to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants