Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please @cesar-benjamin do not use git versions inside
setup.cfg
since it breask existing geonode-project (which use their own requirements.txt in turn).We can consider to adopt your approach, but this must be evaluated in the context of the projects. Maybe in a feature version...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do that because for the geonode-project install method, it install geonode as pip package, so, as python packages dependencies uses setup.cfg and not requirements.txt because the usage of setuptools, so, i have to make chages on setup.cfg to can continue the development and tests, etc.
On the other hand i can understand the thing about breaks, i guess can be used the releases approach, using a release tag for get a freeze stable release, and because geonode is moving now, geonode-project need to move along with.