Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12361] Fix captcha field visualization in signup page #12392

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

giohappy
Copy link
Contributor

@giohappy giohappy commented Jul 8, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https:/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@giohappy giohappy added the backport 4.3.x backport to 4.3.x label Jul 8, 2024
@giohappy giohappy self-assigned this Jul 8, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 8, 2024
@giohappy giohappy linked an issue Jul 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.17%. Comparing base (e0353ec) to head (763f0c6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12392      +/-   ##
==========================================
- Coverage   64.18%   64.17%   -0.01%     
==========================================
  Files         886      886              
  Lines       53286    53289       +3     
  Branches     6585     6586       +1     
==========================================
  Hits        34200    34200              
- Misses      17571    17574       +3     
  Partials     1515     1515              

@giohappy giohappy merged commit d3686f8 into master Jul 8, 2024
16 of 17 checks passed
@giohappy giohappy deleted the issue_12361 branch July 8, 2024 11:53
github-actions bot pushed a commit that referenced this pull request Jul 8, 2024
* Fix captcha field visualization in signup page

* fix formatting

(cherry picked from commit d3686f8)
giohappy added a commit that referenced this pull request Jul 8, 2024
#12393)

* Fix captcha field visualization in signup page

* fix formatting

(cherry picked from commit d3686f8)

Co-authored-by: Giovanni Allegri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.3.x backport to 4.3.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix captcha positioning in Signup page
2 participants