Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After changing metadata of nonSpatial Dataset its converted to geo Dataset #4

Closed
mwallschlaeger opened this issue Mar 22, 2023 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@mwallschlaeger
Copy link

When uploading a dataset as non spatial dataset and editing the metadata of the dataset. The dataset is converted to a spatial dataset

@gannebamm
Copy link
Contributor

@ridoo @matthesrieke please check if this is still valid

@ridoo
Copy link
Member

ridoo commented Jun 6, 2023

@gannebamm I expected such tickets to appear here: https:/orgs/GeoNodeUserGroup-DE/projects/1/views/4

I will have a look at them once everything from 4.1.0 has been merged, and will add bugfixes if the issue is still valid

@ridoo ridoo self-assigned this Jun 6, 2023
@ridoo
Copy link
Member

ridoo commented Jun 19, 2023

Investigation result: The non-spatial dataset is not converted to a spatial one. The link back to the dataset is using the /dataset route instead using the /tabular one. The metadata editor seems to be using the old Django templates.

@ridoo
Copy link
Member

ridoo commented Jun 19, 2023

Correction .. it is indeed converted to spatial-dataset, The /tabular route works for normal /datasets so it appeared to me to be a routing issue on the first glimpse. I will have a deeper look.

@ridoo
Copy link
Member

ridoo commented Jun 19, 2023

The issue is caused by the default resource_manager which is called from layers/views.py#dataset_metadata. The non-spatial importer handler creates a custom resource manager by intent, to avoid conflicting steps when GeoNode tries to sync/handle spatial resources at GeoServer (tiles, styles, gwc, ..).

@gannebamm @matthesrieke It seems that the metadata editor was not tested thoroughly (at least by me), and turns out to be a blind spot for further integration issues.

@ridoo

This comment was marked as off-topic.

@gannebamm

This comment was marked as off-topic.

@gannebamm

This comment was marked as off-topic.

@ridoo

This comment was marked as off-topic.

@ridoo

This comment was marked as off-topic.

@ridoo ridoo transferred this issue from another repository Nov 2, 2023
@ridoo
Copy link
Member

ridoo commented Nov 2, 2023

Note: I have hidden off-topic comments with regard transferring the issues to this repository

@ridoo ridoo added the bug Something isn't working label Jun 7, 2024
ridoo added a commit to GeoNodeUserGroup-DE/geonode that referenced this issue Jun 18, 2024
ridoo added a commit to GeoNodeUserGroup-DE/geonode-mapstore-client that referenced this issue Jun 18, 2024
ridoo added a commit to GeoNodeUserGroup-DE/geonode that referenced this issue Jun 18, 2024
ridoo added a commit that referenced this issue Jun 18, 2024
Now, after fixing #4 using geoserver's resource manager works out-of-the-box. This also fixes the attributes_set which got not created by using the DatapackageResourceManager (which gets obsolete now).
ridoo added a commit that referenced this issue Jun 18, 2024
See https:/GeoNodeUserGroup-DE/geonode-dev-datapackage/issues/3

Now, after fixing #4
using geoserver's resource manager works out-of-the-box. This also fixes the
`attributes_set` which got not created by using the `DatapackageResourceManager`
(which gets obsolete now).
ridoo added a commit to GeoNodeUserGroup-DE/geonode-mapstore-client that referenced this issue Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants