Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filename regex - recognize filenames with multiple dots in it. #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex1704
Copy link

@alex1704 alex1704 commented Sep 2, 2019

No description provided.

@Bankde
Copy link
Contributor

Bankde commented Nov 29, 2019

If you say this case is found often then I'm ok with the change. This PR looks straightforward and clear. I would love if you add unit-test too but we can do that later.

Somehow the repo owner has gone inactive for months :(

@EdOverflow
Copy link
Collaborator

If we could add a couple of unit tests to cover this problem, I would be more than happy to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants