WCMS-22095: Clean up /data route components #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgading
requested changes
Sep 16, 2024
| </Link> | ||
| )} | ||
| </div> | ||
| </div> | ||
| <div className="ds-l-row ds-u-align-items--center"> | ||
| <div className="ds-l-col--12 ds-u-display--flex ds-u-justify-content--between ds-u-align-items--center"> | ||
| <div className="ds-u-font-weight--bold ds-u-margin-bottom--2"> |
There was a problem hiding this comment.
The ds-u-margin-bottom--2 should probably move up to the parent container. When the results disappear during loading so does the margin bottom making the whole section move a little.
dgading
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you need an alpha release.
This PR cleans up some unneeded code from the migration to the new state management. It also updates the loading states on the /data route to match the data table tab page. (While loading, a Spinner should appear in the data table, results text should not appear, and Pagination should not appear)