Translate frontend with i18next #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @alex-ahumada! Will review ASAP |
|
Thanks @dafeder! We should remove debug from i18next config file before release. |
|
Codeclimete warns about: That can't be fixed as i18next language config blocks are similar by design. |
|
@alex-ahumada I know its been a while on these PRs but we do intend to get back to them soon. Not sure if you're able to update them so they merge cleanly again; I imagine your fork has diverged a bit but that would be helpful. I'm sure we can override that codeclimate gate if that's the only blocker 😄 |
|
I'll try update the fork and resolve the conflicts in the coming days @dafeder ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend translation using i18next , with browser language detection and EN/ES translations.
We should probably move translations from config file to individual language files when more languages are added.
resolves #78