Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

Document and complete project-specific test commands #295

Open
dafeder opened this issue Jun 21, 2021 · 1 comment · May be fixed by #290
Open

Document and complete project-specific test commands #295

dafeder opened this issue Jun 21, 2021 · 1 comment · May be fixed by #290

Comments

@dafeder
Copy link
Member

dafeder commented Jun 21, 2021

No description provided.

@dgading
Copy link
Member

dgading commented Jul 23, 2021

@dafeder This was the first pass trying to collect the information from Slack and conversations. How does this look to you?

The goal for the ticket is to have a central location for running Cypress so it isn't installed multiple times per DKAN installation.

Current Setup:

  • data-catalog-app installs its own version of Cypress when added to src/frontend.
  • In DKAN tools dkanTestCypress command installs a version of using npm install cypress then npx to run it. The issue with this is there is no package-lock file so the version may be different and with how fast Cypress updates this could invalidate tests.

Suggested Setup:

  • When using dkan tools to install a new site, we should collect all the tests in one location.
  • We can probably leave the current DKAN tools stuff in place, but instead of using npm install cypress we include a package.json in the DKAN repo so we can control the version of Cypress and just run npm install in that folder.
  • During the frontend link process during a site setup, we should symlink the Cypress folders for the frontend tests with the cypress folder that is in the core DKAN code.
  • Once these are connected, we could then use Cypress cli tools to give options on which tests to run. I think most Cypress fixtures and specs work through sub folders so naming will be important.

@dafeder dafeder linked a pull request Oct 1, 2021 that will close this issue
@dafeder dafeder changed the title Document and complete project-specific Cypress commands Document and complete project-specific test commands Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants