Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value referencer for objects #277

Merged
merged 26 commits into from
Dec 21, 2019
Merged

Value referencer for objects #277

merged 26 commits into from
Dec 21, 2019

Conversation

thierrydallacroce
Copy link
Contributor

No description provided.

@thierrydallacroce
Adjust indentation on multi-line function parameters
af467e5
@thierrydallacroce
Apply Drupal comment standards
7f40ba6
@thierrydallacroce
Use class from global namespace
5980503
@thierrydallacroce
Fix output of error logging message, more appropriate variable naming
4087e69
@thierrydallacroce
If dereferenced property is missing, log instead of returning a value
afe6041
@thierrydallacroce
Only insert valid property values when assembling arrays
3653535
@thierrydallacroce
Clarify some comments
8947e6c
@thierrydallacroce
Log when referencing an item fails, do not add it to its array
1eb7c2d
@thierrydallacroce
Before dereferencing, verify we're dealing with a uuid
f4dcc95
@thierrydallacroce
Fix assignment
3570ced
@thierrydallacroce
Use dependency injection for logger factory service
994c435
@thierrydallacroce
Switch to Drupal's own logger factory
d03a65c
@thierrydallacroce
Correct camel case in test function
4b56aa7
@thierrydallacroce
Start adding loggerService to tests
d69c4f1
@thierrydallacroce
Start to mock uuid isValid
199c874
@thierrydallacroce
Improve indentation and break up long array elements into their own l…
b1e4635 
…ines
@thierrydallacroce
test coverage for dereferenceProperty
fb1be70
@thierrydallacroce
Coverage for dereferenceSingle
9ecfc8a
@thierrydallacroce
Coverage for referenceSingle
74624bc
@thierrydallacroce
Have consistent array formatting
83bed4d
@thierrydallacroce
Fix function name in comment
47ad960
@thierrydallacroce
Coverage for dereferenceSingle
63d9f50
@thierrydallacroce
Coverage for checkExistingReference
ee9de5e
@thierrydallacroce
Fix coverage for createPropertyReference
888baf3
@thierrydallacroce
Apply some coding standards
e67b7a7
@fmizzell fmizzell merged commit 579bb6d into master Dec 21, 2019
@fmizzell fmizzell deleted the value-referencer-for-objects branch December 21, 2019 17:47
@thierrydallacroce thierrydallacroce restored the value-referencer-for-objects branch January 13, 2020 17:25
@fmizzell fmizzell deleted the value-referencer-for-objects branch January 15, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmizzell fmizzell Awaiting requested review from fmizzell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thierrydallacroce @fmizzell