Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

Support PHP 8.1 #4

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Support PHP 8.1 #4

merged 1 commit into from
Mar 3, 2023

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Feb 28, 2023

No description provided.

@paul-m paul-m marked this pull request as draft March 1, 2023 00:18
@paul-m
Copy link
Contributor Author

paul-m commented Mar 1, 2023

Adds return type hinting to PHPUnit methods for PHP 8.1 happiness.

@paul-m paul-m marked this pull request as ready for review March 1, 2023 00:58
@paul-m paul-m requested a review from jastraat March 2, 2023 21:51
jastraat
jastraat approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All matrix automated tests for PHP 7.4, 8.0, and 8.1 passing (as well as with prefer lowest setting). Codesniffer with PSR1 and PSR2 rules. Looks good!

@jastraat jastraat merged commit 510f739 into master Mar 3, 2023
@jastraat jastraat deleted the support-php81 branch March 3, 2023 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jastraat jastraat jastraat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-m @jastraat