-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ifc cleanup #32
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are currently issues with the three abstract base classes defined in
crypt_ifc
, and their implementing child classes.Some places it's the method on the child class that just deviates from a "good" signature on the abc, some places the abstract method signature is too specific to a particular implementation so that other implementations have mismatched signatures.
In general, the abstract methods should be defined with "least common denominator" parameters, always ending with
**kwargs
, and each implementation has to unpack its specific kwargs for required params. Probably the most disruptive part of the work to tidy this all up will be backtracking the implementations that inappropriately drove the abstract method signatures.The text was updated successfully, but these errors were encountered: