Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any reason blocking non-BigQuery (or TEXT) result handler in config_manager.py #1210

Open
scorpionjacky opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
priority: p1 High priority. Fix may be included in the next release. type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.

Comments

@scorpionjacky
Copy link

In config_manager.py line 467 (copied below), any reason non-BigQuery (or TEXT) result handler is blocked?

        else:
            raise ValueError(f"Unknown ResultHandler Class: {result_type}")

Even though we can still use --format <type> for json, csv from the command line w/o using a configuration file, it does block these text result output when using config yaml file if the config file has:

result_handler:
  type: json

Changing the above lines like below unblocked it as I tested it:

        else:
            #raise ValueError(f"Unknown ResultHandler Class: {result_type}")
            return TextResultHandler(result_type)
@helensilva14 helensilva14 added the type: question Request for information or clarification. Not an issue. label Aug 5, 2024
@helensilva14 helensilva14 added the type: feature request 'Nice-to-have' improvement, new feature or different behavior or design. label Aug 23, 2024
@helensilva14
Copy link
Collaborator

Hi @nj1973! Since you just worked on the result handler code for #1240, could you please take a look at this issue? It might be something we can incorporate in the same PR

@helensilva14 helensilva14 added the priority: p1 High priority. Fix may be included in the next release. label Aug 28, 2024
@helensilva14 helensilva14 removed the type: question Request for information or clarification. Not an issue. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 High priority. Fix may be included in the next release. type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants