Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken up-to-date checking for BuildTarTask #1757

Closed
remmeier opened this issue Jun 2, 2019 · 4 comments · Fixed by #1754
Closed

Broken up-to-date checking for BuildTarTask #1757

remmeier opened this issue Jun 2, 2019 · 4 comments · Fixed by #1754
Milestone

Comments

@remmeier
Copy link

remmeier commented Jun 2, 2019

The code defines:

  @InputFiles
  public FileCollection getInputFiles() {
    return GradleProjectProperties.getInputFiles(
        Preconditions.checkNotNull(jibExtension).getExtraDirectory().getPath().toFile(),
        getProject());
  }

  @OutputFile
  public String getOutputFile() {
    return getTargetPath().toString();
  }

whereas getInputFiles leads to:

[...\build\classes\java\main, ...\build\resources\main, ...\build\extraFiles]

but to build an image, third-party and project dependencies must be accounted for as well.

@chanseokoh
Copy link
Member

Thanks for the bug report. We happened to notice this recently too, and I think #1754 fixes it.

@remmeier
Copy link
Author

remmeier commented Jun 3, 2019

oh thx, i did not notice that PR

@remmeier remmeier closed this as completed Jun 3, 2019
@chanseokoh chanseokoh added this to the v1.3.0 milestone Jun 7, 2019
@chanseokoh
Copy link
Member

@remmeier v1.3.0 is released with the fix.

@remmeier
Copy link
Author

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants