Force downgrading to org.apache.httpcomponents:httpclient:4.5.6 prevent URI normalization

[chanseokoh]

They tracked that org.apache.httpcomponents:httpclient:4.5.7 introduced a breaking change by as part of URI normalization. There have been other reports of breakage due to the change too. Details are in googleapis/google-http-java-client#795.

I think it is safe to force this version (googleapis/google-http-java-client#795 (comment)). I verified this fixes #1914 (for Maven) and full integration tests pass.

Fixes #1914.

[chanseokoh]

Oh, wait. Gradle doesn't seem to work this way.

[chanseokoh]

@loosebazooka any idea to make Gradle force that particular version at plugin runtime? I tried runtime('org.apache.httpcomponents:httpclient:4.5.6') everywhere to no avail. Maven works though.

[loosebazooka]

you might have to do it in constraints? but that might lead to some new problems in the unified build.

[loosebazooka]

maybe resolution strategy? https://docs.gradle.org/current/dsl/org.gradle.api.artifacts.ResolutionStrategy.html

[chanseokoh]

Still no luck. ./gradlew -q dependencies shows that every occurrence of Apache httpclient is forced to 4.5.6 (from 4.5.9) in the output, but it doesn't seem forced at plugin runtime.

[chanseokoh]

Alright, Gradle works now. But @loosebazooka said he would look into some more safeguard.

[loosebazooka]

@chanseokoh safeguard doesn't need to hold up this PR, I'll look into it though.

[chanseokoh]

Was about to update CHANGELOG. After that, should we go for releasing 1.5.1?

[TadCordle]

Probably