Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gradle Property and Provider to enable lazy evaluation for jib.container.labels (#3094) #3242

Merged

Conversation

NaitYoussef
Copy link
Contributor

Use Gradle Property and Provider to enable lazy evaluation for jib.container.labels (#3094)

@google-cla google-cla bot added the cla: yes label May 17, 2021
@chanseokoh
Copy link
Member

Thanks! There's a formatting violation that's causing unit-tests failures. You can auto-format the code with ./gradlew googleJavaFormat.

Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for your contribution! Merging this now.

@chanseokoh chanseokoh merged commit cc77462 into GoogleContainerTools:master May 18, 2021
@chanseokoh chanseokoh mentioned this pull request May 18, 2021
@NaitYoussef
Copy link
Contributor Author

Thank you @chanseokoh for your guidance. Looking forward to help with other issues !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants