Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding configuration for exposing ports. #383

Closed
coollog opened this issue Jun 6, 2018 · 4 comments
Closed

Consider adding configuration for exposing ports. #383

coollog opened this issue Jun 6, 2018 · 4 comments
Assignees

Comments

@coollog
Copy link
Contributor

coollog commented Jun 6, 2018

No description provided.

@TadCordle
Copy link
Contributor

TadCordle commented Jun 21, 2018

I'm thinking configuration would be this for gradle:

jib {
  container {
    exposedPorts = ['1000', '2000-2010']
  }
}

For maven:

<configuration>
  <container>
    <exposedPorts>
      <exposedPort>1000</exposedPort>
      <exposedPort>2000-2003</exposedPort>
    </exposedPorts>
  </container>
</configuration>

Would be equivalent to adding this to a Dockerfile:

EXPOSE 1000
EXPOSE 2000-2003

We could name the parameters something different ("expose" instead of "exposedPorts?")

@loosebazooka
Copy link
Member

What's the interaction between this being configured on the container and someone exposing ports in their deployment configuration (kube yaml)?

@coollog
Copy link
Contributor Author

coollog commented Jun 21, 2018

I believe exposing the ports on the container would mean that it would not need to be exposed in the pod container definition in the kube yaml.

@coollog
Copy link
Contributor Author

coollog commented Jun 21, 2018

@TadCordle I think calling it ports would be fine since I don't think it will have any other connotation than meaning the ports to expose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants