Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set timestamp of layer files to 1 instead of 0 #1081

Closed
wants to merge 2 commits into from

Conversation

mbonato
Copy link

@mbonato mbonato commented Oct 1, 2018

About #1079.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@chanseokoh
Copy link
Member

@mbonato please sign the CLA (if you're OK with it) by following the instructions above. Then post a comment saying "I signed it!" in this PR .

@chanseokoh chanseokoh changed the title https:/GoogleContainerTools/jib/issues/1079 Set timestamp of layer files to 1 instead of 0 Oct 2, 2018
@loosebazooka
Copy link
Member

A little update here: #1079 (comment)

@mbonato if you would like to continue this PR, that would be great. If you are unable to or wish not to for any reason, a jib team member will fix this in a new PR.

@mbonato
Copy link
Author

mbonato commented Oct 11, 2018

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@@ -113,7 +113,7 @@ public UnwrittenLayer build() {
TarStreamBuilder tarStreamBuilder = new TarStreamBuilder();
for (TarArchiveEntry entry : sortedFilesystemEntries) {
// Strips out all non-reproducible elements from tar archive entries.
entry.setModTime(0);
entry.setModTime(1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to use 1000 instead of 1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree. I just tried to sign the contributors license agreement. Please feel free to close this PR.

@mbonato
Copy link
Author

mbonato commented Oct 11, 2018

I signed it!

@loosebazooka
Copy link
Member

@mbonato The commit author needs to match your public github email address for the CLA to register.

Currently author is: Martin Bonato <[email protected]>

you can change it by amending the author on the commit:
git commit --amend --author="Martin Bonato <[email protected]>"

You will need to force push to update your fork with the new author information

@googlebot
Copy link

CLAs look good, thanks!

@mbonato
Copy link
Author

mbonato commented Oct 11, 2018

@loosebazooka sorry for that. I reinstalled software and forgot to set the proper user.email config.

@mbonato mbonato closed this Oct 11, 2018
@mbonato
Copy link
Author

mbonato commented Oct 11, 2018

I've set the modTime to 1000 (1 second).

@mbonato mbonato reopened this Oct 11, 2018
@chanseokoh
Copy link
Member

Thanks for your contribution, @mbonato. We just filed another PR with a test, so I'll close this.

@chanseokoh chanseokoh closed this Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants