Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set environment configuration into docker context generator #1154

Closed
wants to merge 1 commit into from

Conversation

dzmitryh
Copy link

This small pr addresses the issue mentioned in the issue -> #890

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@TadCordle
Copy link
Contributor

Hi @dzmitryh, thanks for the contribution, however I actually just fixed this already and am working on releasing 0.9.13 with the changes. I probably should have tagged the original issue in my PRs so it showed up in the thread; sorry!

@TadCordle TadCordle closed this Oct 16, 2018
@dzmitryh
Copy link
Author

@TadCordle no worries, thanks for pushing it forward. Looking forward to see 0.9.13 with that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants