Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra tags to tar image #2054

Merged
merged 5 commits into from
Oct 14, 2019
Merged

Add extra tags to tar image #2054

merged 5 commits into from
Oct 14, 2019

Conversation

TadCordle
Copy link
Contributor

@TadCordle TadCordle commented Oct 10, 2019 •
edited
Loading

Fixes #2043.

Adds jib.to.tags to tars built with jib so docker loading the tar will tag the image appropriately. This also removes the need for DockerClient#tag, since it's done automatically now.

@TadCordle TadCordle requested a review from a team October 10, 2019 21:52
chanseokoh
chanseokoh reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple.

jib-core/src/main/java/com/google/cloud/tools/jib/docker/ImageTarball.java Outdated Show resolved Hide resolved
@TadCordle TadCordle merged commit 3193be5 into master Oct 14, 2019
@TadCordle TadCordle deleted the i2043-manifest-tags branch October 14, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka left review comments

@chanseokoh chanseokoh chanseokoh approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the tags to the manifest.json
4 participants
@TadCordle @loosebazooka @chanseokoh @googlebot