Add Maven plugin extension API #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
reviewed
Apr 8, 2020
...on-api/src/main/java/com/google/cloud/tools/jib/maven/extension/JibMavenPluginExtension.java
Outdated
Show resolved
Hide resolved
...on-common/src/main/java/com/google/cloud/tools/jib/plugins/extension/JibPluginExtension.java
Show resolved
Hide resolved
.../src/main/java/com/google/cloud/tools/jib/plugins/extension/JibPluginExtensionException.java
Outdated
Show resolved
Hide resolved
...on-api/src/main/java/com/google/cloud/tools/jib/maven/extension/JibMavenPluginExtension.java
Outdated
Show resolved
Hide resolved
loosebazooka
approved these changes
Apr 8, 2020
|
Merging this to put up the next PR. If anyone finds an issue, we'll have plenty of time to fix it while things are being shaped up. |
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main plugin extension point is through the following method signature. The focus is on the capability to adjust a build plan prepared by Jib plugins.
JibPluginExtensionExceptionis defined to allow extensions to propagate any problems during extension execution.ExtensionLoggeris to allow extensions to log to the console. Note it is not dependent on any of the logging facilities injib-core.