Run Maven plugin extensions #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -526,6 +533,37 @@ boolean jarRepackagedBySpringBoot() { | |||
| @Override | |||
| public JibContainerBuilder runPluginExtensions(JibContainerBuilder jibContainerBuilder) | |||
| throws JibPluginExtensionException { | |||
| return jibContainerBuilder; | |||
| return runPluginExtensions( | |||
| ServiceLoader.load(JibMavenPluginExtension.class).iterator(), jibContainerBuilder); | |||
There was a problem hiding this comment.
I wonder if we need to create some sort of ordering mechanism so like some file manipulation extension can run after a framework extension has populated all the file?
There was a problem hiding this comment.
Good idea. In a follow-up PR, I'll add a new extension configuration option, as I proposed in the internal doc. I think I will be able to enforce ordering with it.
loosebazooka
approved these changes
Apr 13, 2020
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java
Outdated
Show resolved
Hide resolved
This was referenced Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the standard Service Provider Interfaces (SPI) mechanism to load and run Maven plugin extensions.
This doesn't yet involve the new extension config option (like
<extensions><extension><implementation>com.example.ExtensionClass). The config option can be added in a later PR.With this, we are actually enabling running and testing Maven extensions. A configuration will look like this.