Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Plugin Extension API releases (4 artifacts to Maven Central) #2427

Merged
merged 4 commits into from
May 1, 2020

Conversation

chanseokoh
Copy link
Member

For jib-build-plan, jib-plugins-extension-common, jib-maven-plugin-extension-api, and jib-gradle-plugin-extension-api,

  • build.gradle modified
  • CHANGELOG.md added
  • scripts/prepare_release.sh added

and other minor changes.


Comparing the new scripts with jib-core/prepare_release.sh with

$ diff -u1 jib-core/scripts/prepare_release.sh jib-build-plan/scripts/prepare_release.sh ; \
  diff -u1 jib-core/scripts/prepare_release.sh jib-plugins-extension-common/scripts/prepare_release.sh ; \
  diff -u1 jib-core/scripts/prepare_release.sh jib-maven-plugin-extension-api/scripts/prepare_release.sh ; \
  diff -u1 jib-core/scripts/prepare_release.sh jib-gradle-plugin-extension-api/scripts/prepare_release.sh
--- jib-core/scripts/prepare_release.sh	2020-04-24 13:53:04.793105523 -0400
+++ jib-build-plan/scripts/prepare_release.sh	2020-04-24 13:52:56.913196730 -0400
@@ -1,3 +1,3 @@
 #!/bin/bash -
-# Usage: ./jib-core/scripts/prepare_release.sh <release version>
+# Usage: ./jib-build-plan/scripts/prepare_release.sh <release version>
 
@@ -18,3 +18,3 @@
 DieUsage() {
-  Die "Usage: ./jib-core/scripts/prepare_release.sh <release version> [<post-release-version>]"
+  Die "Usage: ./jib-build-plan/scripts/prepare_release.sh <release version> [<post-release-version>]"
 }
@@ -42,6 +42,6 @@
 # Runs integration tests.
-./gradlew :jib-core:integrationTest --info --stacktrace
+./gradlew :jib-build-plan:integrationTest --info --stacktrace
 
 # Checks out a new branch for this version release (eg. 1.5.7).
-BRANCH=core_release_v${VERSION}
+BRANCH=build_plan_release_v${VERSION}
 git checkout -b ${BRANCH}
@@ -49,3 +49,3 @@
 # Changes the version for release and creates the commits/tags.
-echo | ./gradlew :jib-core:release -Prelease.releaseVersion=${VERSION} ${POST_RELEASE_VERSION:+"-Prelease.newVersion=${POST_RELEASE_VERSION}"}
+echo | ./gradlew :jib-build-plan:release -Prelease.releaseVersion=${VERSION} ${POST_RELEASE_VERSION:+"-Prelease.newVersion=${POST_RELEASE_VERSION}"}
 
@@ -53,3 +53,3 @@
 git push origin ${BRANCH}
-git push origin v${VERSION}-core
+git push origin v${VERSION}-build-plan
 
--- jib-core/scripts/prepare_release.sh	2020-04-24 13:53:04.793105523 -0400
+++ jib-plugins-extension-common/scripts/prepare_release.sh	2020-04-24 14:07:40.186992570 -0400
@@ -1,3 +1,3 @@
 #!/bin/bash -
-# Usage: ./jib-core/scripts/prepare_release.sh <release version>
+# Usage: ./jib-plugins-extension-common/scripts/prepare_release.sh <release version>
 
@@ -18,3 +18,3 @@
 DieUsage() {
-  Die "Usage: ./jib-core/scripts/prepare_release.sh <release version> [<post-release-version>]"
+  Die "Usage: ./jib-plugins-extension-common/scripts/prepare_release.sh <release version> [<post-release-version>]"
 }
@@ -42,6 +42,6 @@
 # Runs integration tests.
-./gradlew :jib-core:integrationTest --info --stacktrace
+./gradlew :jib-plugins-extension-common:integrationTest --info --stacktrace
 
 # Checks out a new branch for this version release (eg. 1.5.7).
-BRANCH=core_release_v${VERSION}
+BRANCH=extension_common_release_v${VERSION}
 git checkout -b ${BRANCH}
@@ -49,3 +49,3 @@
 # Changes the version for release and creates the commits/tags.
-echo | ./gradlew :jib-core:release -Prelease.releaseVersion=${VERSION} ${POST_RELEASE_VERSION:+"-Prelease.newVersion=${POST_RELEASE_VERSION}"}
+echo | ./gradlew :jib-plugins-extension-common:release -Prelease.releaseVersion=${VERSION} ${POST_RELEASE_VERSION:+"-Prelease.newVersion=${POST_RELEASE_VERSION}"}
 
@@ -53,3 +53,3 @@
 git push origin ${BRANCH}
-git push origin v${VERSION}-core
+git push origin v${VERSION}-extension-common
 
--- jib-core/scripts/prepare_release.sh	2020-04-24 13:53:04.793105523 -0400
+++ jib-maven-plugin-extension-api/scripts/prepare_release.sh	2020-04-24 14:06:15.831965501 -0400
@@ -1,3 +1,3 @@
 #!/bin/bash -
-# Usage: ./jib-core/scripts/prepare_release.sh <release version>
+# Usage: ./jib-build-plan/scripts/prepare_release.sh <release version>
 
@@ -18,3 +18,3 @@
 DieUsage() {
-  Die "Usage: ./jib-core/scripts/prepare_release.sh <release version> [<post-release-version>]"
+  Die "Usage: ./jib-maven-plugin-extension-api/scripts/prepare_release.sh <release version> [<post-release-version>]"
 }
@@ -42,6 +42,6 @@
 # Runs integration tests.
-./gradlew :jib-core:integrationTest --info --stacktrace
+./gradlew :jib-maven-plugin-extension-api:integrationTest --info --stacktrace
 
 # Checks out a new branch for this version release (eg. 1.5.7).
-BRANCH=core_release_v${VERSION}
+BRANCH=maven_extension_release_v${VERSION}
 git checkout -b ${BRANCH}
@@ -49,3 +49,3 @@
 # Changes the version for release and creates the commits/tags.
-echo | ./gradlew :jib-core:release -Prelease.releaseVersion=${VERSION} ${POST_RELEASE_VERSION:+"-Prelease.newVersion=${POST_RELEASE_VERSION}"}
+echo | ./gradlew :jib-maven-plugin-extension-api:release -Prelease.releaseVersion=${VERSION} ${POST_RELEASE_VERSION:+"-Prelease.newVersion=${POST_RELEASE_VERSION}"}
 
@@ -53,3 +53,3 @@
 git push origin ${BRANCH}
-git push origin v${VERSION}-core
+git push origin v${VERSION}-maven-extension
 
--- jib-core/scripts/prepare_release.sh	2020-04-24 13:53:04.793105523 -0400
+++ jib-gradle-plugin-extension-api/scripts/prepare_release.sh	2020-04-24 14:06:44.655633021 -0400
@@ -1,3 +1,3 @@
 #!/bin/bash -
-# Usage: ./jib-core/scripts/prepare_release.sh <release version>
+# Usage: ./jib-gradle-plugin-extension-api/scripts/prepare_release.sh <release version>
 
@@ -18,3 +18,3 @@
 DieUsage() {
-  Die "Usage: ./jib-core/scripts/prepare_release.sh <release version> [<post-release-version>]"
+  Die "Usage: ./jib-gradle-plugin-extension-api/scripts/prepare_release.sh <release version> [<post-release-version>]"
 }
@@ -42,6 +42,6 @@
 # Runs integration tests.
-./gradlew :jib-core:integrationTest --info --stacktrace
+./gradlew :jib-gradle-plugin-extension-api:integrationTest --info --stacktrace
 
 # Checks out a new branch for this version release (eg. 1.5.7).
-BRANCH=core_release_v${VERSION}
+BRANCH=gradle_extension_release_v${VERSION}
 git checkout -b ${BRANCH}
@@ -49,3 +49,3 @@
 # Changes the version for release and creates the commits/tags.
-echo | ./gradlew :jib-core:release -Prelease.releaseVersion=${VERSION} ${POST_RELEASE_VERSION:+"-Prelease.newVersion=${POST_RELEASE_VERSION}"}
+echo | ./gradlew :jib-gradle-plugin-extension-api:release -Prelease.releaseVersion=${VERSION} ${POST_RELEASE_VERSION:+"-Prelease.newVersion=${POST_RELEASE_VERSION}"}
 
@@ -53,3 +53,3 @@
 git push origin ${BRANCH}
-git push origin v${VERSION}-core
+git push origin v${VERSION}-gradle-extension
 

@loosebazooka
Copy link
Member

loosebazooka commented Apr 24, 2020

So do we need to adjust the build files at this point to reference published artifacts? Or are we not there yet?

I guess we need to release them first, huh?

@chanseokoh
Copy link
Member Author

So do we need to adjust the build files at this point to reference published artifacts? Or are we not there yet?

I guess we need to release them first, huh?

Yeah, we can reference them only after they become available.

@chanseokoh chanseokoh merged commit 263636d into master May 1, 2020
@chanseokoh chanseokoh deleted the publish-extension-artifacts branch May 1, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants