Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jib-{maven|gradle}-plugin to use published extension API #2446

Merged
merged 7 commits into from
May 19, 2020

Conversation

chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented May 1, 2020

Migrate all projects to use published artifacts. I missed jib-core in #2443, so fixing it here too.

I have checked the contents of all 4 artifacts, and there's no class duplication in any published artifact.

@chanseokoh chanseokoh requested a review from a team May 4, 2020 16:31
@chanseokoh
Copy link
Member Author

Ugh, the published Gradle API is the older version without the custom extension properties. I need to republish the API.

@chanseokoh
Copy link
Member Author

$ ./gradlew buildEnv with the plugin built at HEAD (2.2.1-SNAPSHOT) shows the following classpath graph.

classpath
...
\--- com.google.cloud.tools.jib:com.google.cloud.tools.jib.gradle.plugin:2.2.1-SNAPSHOT
     \--- com.google.cloud.tools:jib-gradle-plugin:2.2.1-SNAPSHOT
          +--- com.google.cloud.tools:jib-build-plan:0.1.0

          ...

          +--- com.google.cloud.tools:jib-plugins-extension-common:0.1.0
          \--- com.google.cloud.tools:jib-gradle-plugin-extension-api:0.1.1
               +--- com.google.cloud.tools:jib-build-plan:0.1.0
               \--- com.google.cloud.tools:jib-plugins-extension-common:0.1.0

loosebazooka
loosebazooka previously approved these changes May 12, 2020
@chanseokoh
Copy link
Member Author

This works, and nothing major breaks if we merge this. However, I'd like to complete migration after publishing new API being updated by #2464.

@chanseokoh chanseokoh added this to the v2.3.0 milestone May 18, 2020
@chanseokoh
Copy link
Member Author

Ready for review! Updated the versions after publishing new artifacts. Although jib-gradle-plugin-extension-api currently depends on jib-plugins-extension-common:0.1.0, we should be good at runtime as 0.2.0 will be used.

          +--- com.google.cloud.tools:jib-plugins-extension-common:0.2.0
          \--- com.google.cloud.tools:jib-gradle-plugin-extension-api:0.2.0
               +--- com.google.cloud.tools:jib-build-plan:0.1.0
               \--- com.google.cloud.tools:jib-plugins-extension-common:0.1.0 -> 0.2.0

If a Travis build fails, it would be due to the Google Maven Central mirror running behind syncing.

@chanseokoh chanseokoh merged commit 01c3c27 into master May 19, 2020
@chanseokoh chanseokoh deleted the migrate-to-maven-central-deps branch May 19, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants