Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message about global Jib config and update CHANGELOGs #3144

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented Mar 16, 2021

Closes #3138.

From #2996,

  • Previously, any error from handling config.json was a warning and didn't cause a build to fail. Now we consider this as loading a global config, a build will fail if the code cannot load it.

Also updated the error message. The user in #3138 mistakenly thought they have to create the file manually.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #3144 (52460a9) into master (f8bc2e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3144   +/-   ##
=========================================
  Coverage     71.08%   71.08%           
  Complexity     2320     2320           
=========================================
  Files           280      280           
  Lines          9825     9825           
  Branches        992      992           
=========================================
  Hits           6984     6984           
  Misses         2495     2495           
  Partials        346      346           
Impacted Files Coverage Δ Complexity Δ
.../jib/plugins/common/globalconfig/GlobalConfig.java 82.50% <ø> (ø) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bc2e5...52460a9. Read the comment docs.

@chanseokoh chanseokoh changed the title Update missing CHANGELOG entries Improve error message about global Jib config and update CHANGELOGs Mar 16, 2021
@chanseokoh chanseokoh merged commit dcb9905 into master Mar 17, 2021
@chanseokoh chanseokoh deleted the update-changelogs branch March 17, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to open or parse global Jib config file
2 participants