Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System property 'jibSerialize' causes build steps to be executed serially #682

Merged
merged 7 commits into from
Jul 24, 2018
Merged

System property 'jibSerialize' causes build steps to be executed serially #682

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
515b21e
System property 'jibSerialize' causes build steps to be executed seri…
briandealwis Jul 20, 2018
88f18d7
Turn jibSerialize property into true/false
briandealwis Jul 23, 2018
780b1bc
Merge remote-tracking branch 'origin/master' into HEAD
briandealwis Jul 23, 2018
76fbdf0
Merge branch 'master' into serialize
briandealwis Jul 23, 2018
cdd4813
Merge branch 'master' into serialize
briandealwis Jul 24, 2018
6b8153f
Merge branch 'master' into serialize
briandealwis Jul 24, 2018
1cf5b59
Merge branch 'master' into serialize
briandealwis Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.util.Collections;
import java.util.List;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import javax.annotation.Nullable;

Expand All @@ -44,8 +45,7 @@
*/
public class StepsRunner {

private final ListeningExecutorService listeningExecutorService =
MoreExecutors.listeningDecorator(Executors.newCachedThreadPool());
private final ListeningExecutorService listeningExecutorService;
private final BuildConfiguration buildConfiguration;
private final SourceFilesConfiguration sourceFilesConfiguration;
private final Cache baseLayersCache;
Expand Down Expand Up @@ -76,6 +76,12 @@ public StepsRunner(
this.sourceFilesConfiguration = sourceFilesConfiguration;
this.baseLayersCache = baseLayersCache;
this.applicationLayersCache = applicationLayersCache;

ExecutorService executorService =
Boolean.getBoolean("jibSerialized")
Copy link
Member

@chanseokoh chanseokoh Jul 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briandealwis is this supposed to be jibSerialize or jibSerialized? If the latter, please update the title of the PR. Can you also update the CHANGELOG files?

? MoreExecutors.newDirectExecutorService()
: Executors.newCachedThreadPool();
listeningExecutorService = MoreExecutors.listeningDecorator(executorService);
}

public StepsRunner runRetrieveTargetRegistryCredentialsStep() {
Expand Down