Improve logging for pulling base image #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
reviewed
Jul 20, 2018
| buildConfiguration | ||
| .getBuildLogger() | ||
| .lifecycle( | ||
| "Trying again for " + buildConfiguration.getBaseImageReference() + " with auth..."); |
There was a problem hiding this comment.
How about:
"The base image repository requires auth. Trying again for ..."
coollog
reviewed
Jul 20, 2018
| .lifecycle( | ||
| "Getting base image " | ||
| + buildConfiguration.getBaseImageReference() | ||
| + " with no auth..."); |
There was a problem hiding this comment.
Since the default case is gcr.io/distroless/java, I think we can leave off the with no auth here, and then below it can be what @chanseokoh recommended.
chanseokoh
approved these changes
Jul 23, 2018
|
I'd rather include the image ref so that it's clear that the message is tied to the previous pull. |
Gosh, I keep forgetting that I need to escape brackets, haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of related to #620. This PR adds a little bit of logging around the
PullBaseImageStepto notify the user that jib will retry when the initial unauthenticated pull fails.Perhaps the "auth" is a bit too encoded.