Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make createdBy in history configurable #899

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Make createdBy in history configurable #899

merged 1 commit into from
Aug 29, 2018

Conversation

TadCordle
Copy link
Contributor

Fixes #875

created_by is now jib-gradle-plugin for gradle and jib-maven-plugin for maven

briandealwis
briandealwis approved these changes Aug 29, 2018
View reviewed changes
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other places where we would want to refer to tool ID? Wondering if we should name this like setToolId().

@TadCordle
Copy link
Contributor Author

@briandealwis Hmm we use it for the User-Agent header suffix and a few other random places for logging. Maybe it'd be good to combine these in the future (I don't think I want to make any changes like that in this PR though).

@TadCordle TadCordle merged commit fb29224 into master Aug 29, 2018
@TadCordle TadCordle deleted the history-createdby branch August 29, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

@coollog coollog Awaiting requested review from coollog

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TadCordle @briandealwis @googlebot