Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] use PR target branch instead od repository main one #2

Open
mcosta74 opened this issue Mar 31, 2022 · 2 comments
Open

Comments

@mcosta74
Copy link

would be nice if for a PR you can check against the target branch instead of using the main one

@mcosta74 mcosta74 changed the title [FEATURE REQUEST] [FEATURE REQUEST] use PR target branch instead od repository main one Mar 31, 2022
@mcosta74 mcosta74 reopened this Mar 31, 2022
@GreatWizard
Copy link
Owner

Hello @mcosta74 ,

Thanks for your feedback :)
I made a PR to add this option: #5

What do you think?

@MikeMatusz
Copy link

I'm currently considering adopting this GH action, so I don't have real experience with it yet, but noticed this issue since it sounds like the behavior I would like to set up. If I'm understanding @mcosta74 correctly, I'm not sure #5 would help because that just lets you trigger "default branch mode" on a different branch, which could be useful in its own right. But I also think it might already be possible to do what was requested.

The "target branch diff coverage" is defined by the base-summary-filename option, so as long as the target branch has a summary report on the wiki stored in a path that can be derived from the target branch metadata available, I could set up my PR workflow to pass the filename associated with the target branch, which would generate the differ report against that branch instead of the main branch. Does that seem accurate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants