Added ability to add attributes to html() method #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to add attributes like `id` , `class`, `alt` to html() method
Uses
Image::open('open.jpg')->html($title = 'some title', $type = 'jpg' , array('class'=>'test pull-right','id'=>'test','alt' => 'name')));
`NULL` can also be provided if don't want any attributes just want to change the image quality
| public function html($title = '', $type = 'jpg', $attributes = array(), $quality = 80) | ||
| { | ||
| $html = array(); | ||
| if (!empty($attributes)) { |
There was a problem hiding this comment.
If you don't want to set any attribute, only want to change the quality of image you can pass null and empty array or no array at all. That will just change the quality of image and no attribute are added to the output.
Eg: html('title','jpeg','',20)) or html('title','jpeg',NULL,20)) or html('title','jpeg',array(),20))
There was a problem hiding this comment.
Yes, but since the foreach loop will not have any effect in this case the test is not useful
There was a problem hiding this comment.
foreach is not execute only when you pass the NULL , if you pass an empty array or and empty string it will executed at least one time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to add attributes like
id,class,altto html() methodUses
NULLcan also be provided if don't want any attributes just want to change the image quality