-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poor performance when overrunning a large obfuscation dictionary #413
Comments
The dictionary performance should be improved in 7.6 with the following commit: 03d7eff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In one project, we use an obfuscation dictionary with 10,000 entries. We found that most CPU time was spent in
proguard.obfuscate.DictionaryNameFactory.nextName
.It turns out we had more than 10,000 symbols to obfuscate in the project and ran out the dictionary.
DictionaryNameFactory
falls back to generating fresh names and checking them against the dictionary so it doesn't generate a duplicate, but this duplicate-checking uses a linear scan (List#contains
, line 255), so our large dictionary was causing this code path to be very slow.proguard/base/src/main/java/proguard/obfuscate/DictionaryNameFactory.java
Lines 250 to 255 in 3a9b11b
The text was updated successfully, but these errors were encountered: