Check remote is bare when creating repo from path #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/LocalRegistry.jl
Outdated
| @@ -199,6 +207,7 @@ function do_register(package, registry; | |||
| clean_registry = true | |||
|
|
|||
| git = gitcmd(registry_path, gitconfig) | |||
|
|
|||
src/LocalRegistry.jl
Outdated
| @@ -421,6 +430,11 @@ function get_remote_repo(package_path, gitconfig) | |||
| return repos[1] | |||
| end | |||
|
|
|||
| function is_bare_repo(registry_path, gitconfig) | |||
| git = gitcmd(registry_path, gitconfig) | |||
| parse(Bool, read(`$git rev-parse --is-bare-repository`, String)) | |||
There was a problem hiding this comment.
No need for the double space.
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 98.31% 98.36% +0.05%
==========================================
Files 1 1
Lines 178 184 +6
==========================================
+ Hits 175 181 +6
Misses 3 3
Continue to review full report at Codecov.
|
|
The CI failure is annoying. It's real to the extent that it happens in the new code but only for the combination of Windows and Julia 1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is not exactly elegant, but...
I can't figure out how to check if remote is bare. Instead, if the user specifies the remote URL as a path, it runs
git rev-parseto check if the remote URL is bare.