Stream compression does not work when res.body is a stream (no res.stream) #8

btakita · 2023-12-14T00:19:40Z

When returning a ReadableStream from an Elysia route, .body is the ReadableStream while .stream is undefined.

The code in question is:

https:/Gusb3ll/elysia-compression/blob/main/src/index.ts#L76C42-L76C42

Not only does the stream not compress, but the response is hijacked to be {} instead of the html.

To fix, I inserted:

const stream = ctx.response?.stream ?? ctx.response?.body;

Edit:

I have never seen res.stream before. Is this in the web standard or is this something added by Elysia or Bun?

Note the route looks something like:

app.get('/', ()=>
  new Response(
    new ReadableStream({
      start(controller) {
        controller.enqueue('<html></html>')
        controller.close()
      }
    }),
    {
      headers: { 'Content-Type': 'text/html;charset=UTF-8' }
    }
  ))

The text was updated successfully, but these errors were encountered:

Gusb3ll added the bug Something isn't working label Dec 16, 2023

Gusb3ll self-assigned this Dec 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stream compression does not work when res.body is a stream (no res.stream) #8

Stream compression does not work when res.body is a stream (no res.stream) #8

btakita commented Dec 14, 2023 •

edited

Loading

Stream compression does not work when res.body is a stream (no res.stream) #8

Stream compression does not work when res.body is a stream (no res.stream) #8

Comments

btakita commented Dec 14, 2023 • edited Loading

btakita commented Dec 14, 2023 •

edited

Loading