-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL Error for Kia Canada #254
Comments
since it's a TLS issue it could be an issue with your machine and or dependencies. I'd try in another machine or even in a docker container to troubleshoot. |
Tried with a linux machine and node 20.4.0 with the same error :( I think both are using openssl@3 |
Just tried on a GitHub Codespace
|
can you try |
Hmm, nope:
|
I just ran debug with
|
Same thing is happening with the login method, it's just not logging the response by default. I looked at upgrading |
Hmmm I tried without I have to assume the TLS settings were changed on their server causing this issue 🤔. Code: fetch('https://kiaconnect.ca/test')
.then(res => res.json())
.then(console.log)
.catch(console.error); Error:
|
Looks like OpenSSL 3, which newer versions of node are compiled against, does not like the certificate. Can’t get a workaround working unfortunately. Guess we wait for the cert to expire, which is luckily not a terribly long wait. |
Could you downgrade node and try to see if that's a workaround for now? |
@Hacksore Yep, downgrading to node 16 is MUCH happier:
|
Woot woot! Maybe once they update the cert this won't be an issue like you said 😅. Closing for now as we have a workaround, thanks for digging into this. |
Hello @Hacksore and team, Have we found a solutions for issue? The workaround provided is not going to work for much longer since node.js 16 has been deprecated. Kind regards, |
related got issue sindresorhus/got#2271 We could switch to fetch which has a workaround. However, that's a considerable amount of work and something is probably bound to break. import crypto from 'crypto';
import { Agent } from 'undici';
fetch('https://kiaconnect.ca', {
dispatcher: new Agent({
connect: {
rejectUnauthorized: false,
secureOptions: crypto.constants.SSL_OP_LEGACY_SERVER_CONNECT,
},
}),
}).then((res) => console.log(res.status)); If anyone wants to ship a PR 🙏 |
A fix is indeed needed. The new Homey Home automation platform only runs on node 18. So Bluelinky is broken there :( See details here: https://community.homey.app/t/app-pro-kia-and-hyundai/32487/560 Someone here that can do a PR? 🙏 |
Why is this closed? |
I don't have bandwidth to fix it, PRs are welcomed tho! |
FYI I ran into this with a US Hyundai. I can't remember right now if it was an old version of Bluelinky that I was trying when I added this comment or the current version. |
Describe the bug
When running npm debug I'm getting:
Usefull info(please complete the following information):
master
branch)Additional context
Node:
18.16.1
Happy to privately provide login details.
The text was updated successfully, but these errors were encountered: