Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lints in nightly CI #105

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Fix lints in nightly CI #105

merged 1 commit into from
Jan 21, 2024

Conversation

HadrienG2
Copy link
Owner

@HadrienG2 HadrienG2 commented Jan 21, 2024

Technically, one of the "fixes" is actually a workaround for a clippy false positive. But I actually like the workaround version better.

Along the way, this also fixes a trait bound bug where the "external" PartialEq impl of XML did not work because I expressed it in terms of str, when string comparison traits are actually implemented for &str.

Copy link

semanticdiff-com bot commented Jan 21, 2024

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Overall, the semantic diff is 49% smaller than the GitHub diff.

Filename Status
✔️ src/lib.rs 77.84% smaller
✔️ src/topology/export/xml.rs 35.53% smaller

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9ad1103) 65.28% compared to head (8bfd315) 65.28%.

Files Patch % Lines
src/topology/export/xml.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   65.28%   65.28%           
=======================================
  Files          43       43           
  Lines        4632     4632           
=======================================
  Hits         3024     3024           
  Misses       1608     1608           
Flag Coverage Δ
ubuntu-latest 66.53% <0.00%> (ø)
windows-latest 63.90% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HadrienG2 HadrienG2 merged commit a670ec4 into main Jan 21, 2024
102 of 103 checks passed
@HadrienG2 HadrienG2 deleted the fix-nightly-ci branch January 21, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant