Retry session #193
Open
Retry session #193
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhper
reviewed
Jan 7, 2018
| @@ -25,8 +25,7 @@ defmodule Hound.Session do | |||
| desiredCapabilities: capabilities | |||
| } | |||
|
|
|||
| # No retries for this request | |||
| make_req(:post, "session", params) | |||
There was a problem hiding this comment.
@HashNuke Do you remember why we did not have any retries for this request?
|
Thank you, and sorry for the delay. |
|
I would very much like this fixed as well if there's not a reason for the retries being stripped out. it also affects my use case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've found with CircleCI that we randomly received timeouts when using standalone selenium Chrome instance.
From time to time these timeouts occur more often and seem to randomly disappear again. My suspicion is that the networking of CircleCI (I believe they use AWS) cannot be relied upon to disable the timeouts in the tests.
Is there a particular reason why the start of the session is not retried?