Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most impactful Elixir 1.17 warnings #258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michallepicki
Copy link

@michallepicki michallepicki commented Jun 2, 2024

In 825f3a9 I've fixed a warning about invoking a function without parentheses. It shows at run-time and looks like this:

warning: using map.field notation (without parentheses) to invoke function Hound.Browser.ChromeHeadless.default_user_agent() is deprecated, you must add parentheses instead: remote.function()
  (hound 1.1.1) lib/hound/browser.ex:16: Hound.Browser.make_capabilities/2
  (hound 1.1.1) lib/hound/session.ex:45: Hound.Session.make_capabilities/2
  (hound 1.1.1) lib/hound/session.ex:23: Hound.Session.create_session/2
  (hound 1.1.1) lib/hound/session_server.ex:99: Hound.SessionServer.create_session/2
  (hound 1.1.1) lib/hound/session_server.ex:78: Hound.SessionServer.handle_call/3
  (stdlib 6.0) gen_server.erl:2209: :gen_server.try_handle_call/4
  (stdlib 6.0) gen_server.erl:2238: :gen_server.handle_msg/6
  (stdlib 6.0) proc_lib.erl:329: :proc_lib.init_p_do_apply/3

While at it, because of elixir-lang/elixir#13132 , in 074c841 I've also fixed another warning in the mix.exs file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant