Skip to content

Commit

Permalink
fix: Fix problems with unnecessary scroll (#170) (#172)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jack251970 authored Oct 7, 2024
1 parent 6d81aa8 commit 1437c09
Show file tree
Hide file tree
Showing 3 changed files with 101 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ private void PrepareContextMenuWindow()

frame.Loaded += (_, _) =>
{
// Set the window style to PopupWindow to make the title bar invisible
HwndUtilities.SetWindowStyle((nint)ContextMenuWindowHandle!, HwndUtilities.WindowStyle.PopupWindow);
flyout.ShowAt(window.Content, new FlyoutShowOptions
{
ShowMode = FlyoutShowMode.Transient,
Expand Down
98 changes: 98 additions & 0 deletions src/libs/H.NotifyIcon/Interop/HwndUtilities.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
using System.ComponentModel;
using System.Runtime.InteropServices;

namespace H.NotifyIcon.Interop;

/// <summary>
/// A set of HWND Helper Methods
/// Codes are edited from: https:/dotMorten/WinUIEx
/// </summary>
public static class HwndUtilities
{
/// <summary>
/// Sets the current window style
/// </summary>
/// <param name="hWnd">Window handle</param>
/// <param name="newStyle"></param>
[SupportedOSPlatform("windows5.0")]
public static void SetWindowStyle(IntPtr hWnd, WindowStyle newStyle)
{
var h = new HWND(hWnd);
var currentStyle = PInvoke.GetWindowLong(h, WINDOW_LONG_PTR_INDEX.GWL_STYLE);
var r = PInvoke.SetWindowLong(h, WINDOW_LONG_PTR_INDEX.GWL_STYLE, (int)newStyle);
if (r != currentStyle)
Marshal.ThrowExceptionForHR(Marshal.GetLastWin32Error());
// Redraw window
_ = PInvoke.SetWindowPos(h, new HWND(IntPtr.Zero), 0, 0, 0, 0, SET_WINDOW_POS_FLAGS.SWP_FRAMECHANGED | SET_WINDOW_POS_FLAGS.SWP_NOMOVE | SET_WINDOW_POS_FLAGS.SWP_NOSIZE | SET_WINDOW_POS_FLAGS.SWP_NOZORDER | SET_WINDOW_POS_FLAGS.SWP_NOOWNERZORDER);
}

#pragma warning disable CA1069 // Enums values should not be duplicated
/// <summary>
/// Based on <see href="https://learn.microsoft.com/zh-cn/windows/win32/winmsg/window-styles"/>
/// </summary>
public enum WindowStyle : int
{
/// <summary>The window has a thin-line border.</summary>
Border = 0x00800000,
/// <summary>The window has a title bar (includes the BORDER style).</summary>
Caption = 0x00C00000,
/// <summary>The window is a child window. A window with this style cannot have a menu bar. This style cannot be used with the POPUP style.</summary>
Child = 0x40000000,
/// <summary>Same as the <see cref="Child"/> style.</summary>
ChildWindow = 0x40000000,
/// <summary>Excludes the area occupied by child windows when drawing occurs within the parent window. This style is used when creating the parent window.</summary>
[Obsolete("Use ClipChildren")]
[EditorBrowsable(EditorBrowsableState.Never)]
ChildChildren = 0x02000000,
/// <summary>Excludes the area occupied by child windows when drawing occurs within the parent window. This style is used when creating the parent window.</summary>
ClipChildren = 0x02000000,
/// <summary>Clips child windows relative to each other; that is, when a particular child window receives a WM_PAINT message, the CLIPSIBLINGS style clips all other overlapping child windows out of the region of the child window to be updated. If CLIPSIBLINGS is not specified and child windows overlap, it is possible, when drawing within the client area of a child window, to draw within the client area of a neighboring child window.</summary>
ClipSiblings = 0x04000000,
/// <summary>The window is initially disabled. A disabled window cannot receive input from the user. To change this after a window has been created, use the EnableWindow function.</summary>
Disabled = 0x08000000,
/// <summary>The window has a border of a style typically used with dialog boxes. A window with this style cannot have a title bar.</summary>
DlgFrame = 0x00400000,
/// <summary>The window is the first control of a group of controls. The group consists of this first control and all controls defined after it, up to the next control with the GROUP style. The first control in each group usually has the TABSTOP style so that the user can move from group to group. The user can subsequently change the keyboard focus from one control in the group to the next control in the group by using the direction keys.
/// You can turn this style on and off to change dialog box navigation. To change this style after a window has been created, use the SetWindowLong function.</summary>
Group = 0x00020000,
/// <summary>The window has a horizontal scroll bar.</summary>
HScroll = 0x00100000,
/// <summary>The window is initially minimized. Same as the MINIMIZE style.</summary>
Iconic = 0x20000000,
/// <summary>The window is initially maximized.</summary>
Maximize = 0x01000000,
/// <summary>The window has a maximize button. Cannot be combined with the EX_CONTEXTHELP style. The SYSMENU style must also be specified.</summary>
MaximizeBox = 0x00010000,
/// <summary>The window is initially minimized. Same as the ICONIC style.</summary>
Minimize = 0x20000000,
/// <summary>The window has a minimize button. Cannot be combined with the EX_CONTEXTHELP style. The SYSMENU style must also be specified.</summary>
MinimizeBox = 0x00020000,
/// <summary>The window is an overlapped window. An overlapped window has a title bar and a border. Same as the TILED style.</summary>
Overlapped = 0x00000000,
/// <summary>The window is an overlapped window. Same as the TILEDWINDOW style.</summary>
OverlappedWindow = (Overlapped | Caption | SysMenu | ThickFrame | MinimizeBox | MaximizeBox),
/// <summary>The window is a pop-up window. This style cannot be used with the CHILD style.</summary>
Popup = unchecked((int)0x80000000),
/// <summary>The window is a pop-up window. The CAPTION and POPUPWINDOW styles must be combined to make the window menu visible.</summary>
PopupWindow = unchecked((int)(0x80000000 | Border | SysMenu)),
/// <summary>The window has a sizing border. Same as the THICKFRAME style.</summary>
SizeBox = 0x00040000,
/// <summary>The window has a window menu on its title bar. The CAPTION style must also be specified.</summary>
SysMenu = 0x00080000,
/// <summary>The window is a control that can receive the keyboard focus when the user presses the TAB key. Pressing the TAB key changes the keyboard focus to the next control with the TABSTOP style.
/// You can turn this style on and off to change dialog box navigation. To change this style after a window has been created, use the SetWindowLong function. For user-created windows and modeless dialogs to work with tab stops, alter the message loop to call the IsDialogMessage function.</summary>
TabStop = 0x00010000,
/// <summary>The window has a sizing border. Same as the SIZEBOX style.</summary>
ThickFrame = 0x00040000,
/// <summary>The window is an overlapped window. An overlapped window has a title bar and a border. Same as the OVERLAPPED style.</summary>
Tiled = 0x00000000,
/// <summary>The window is an overlapped window. Same as the OVERLAPPEDWINDOW style.</summary>
TiledWindow = (Overlapped | Caption | SysMenu | ThickFrame | MinimizeBox | MaximizeBox),
/// <summary>The window is initially visible.
/// This style can be turned on and off by using the ShowWindow or SetWindowPos function.</summary>
Visible = 0x10000000,
/// <summary>The window has a vertical scroll bar.</summary>
VScroll = 0x00200000,
}
#pragma warning restore CA1069 // Enums values should not be duplicated
}
1 change: 1 addition & 0 deletions src/libs/H.NotifyIcon/NativeMethods.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ SetForegroundWindow
ShowWindow
SetWindowLong
GetWindowLong
SetWindowPos
DefSubclassProc
SetWindowSubclass
GetClientRect
Expand Down

0 comments on commit 1437c09

Please sign in to comment.