Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addHeader function for neko and php #9063

Closed
wants to merge 2 commits into from
Closed

Add addHeader function for neko and php #9063

wants to merge 2 commits into from

Conversation

lublak
Copy link
Contributor

@lublak lublak commented Dec 25, 2019

@RealyUniqueName RealyUniqueName added this to the Release 4.1 milestone Dec 25, 2019
@Simn Simn added the waiting-for-feedback We need more information to deal with this issue. label Feb 17, 2020
@Simn
Copy link
Member

Simn commented Feb 17, 2020

Please update the branch, CI is freaking out.

Looks like Web survived my std purge... I'm inclined to move this to hx3compat and just let it sit there because I don't want to have this in the standard library. Still, if this small change makes your life any better I'm fine with merging this PR.

@RealyUniqueName
Copy link
Member

I'm inclined to move this to hx3compat and just let it sit there because I don't want to have this in the standard library.

#9153

@lublak
Copy link
Contributor Author

lublak commented Feb 17, 2020

"Web" is not important to me. Only the add_header for neko and tora, since I have my own "web" implementation.
This pull request is just for those, who need it in the standard library.
I'm fine to skip this pull request.

@Simn
Copy link
Member

Simn commented Feb 18, 2020

Alright then, thanks for the effort.

@Simn Simn closed this Feb 18, 2020
@lublak lublak deleted the add_header branch March 13, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting-for-feedback We need more information to deal with this issue.
Projects
None yet
Milestone
Release 4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lublak @Simn @RealyUniqueName